2020
Kinglykrab
Add GetDisplayAC() to Perl/Lua.
$client->GetDisplayAC();
client:GetDisplayAC();
Add DyeArmorBySlot() to Perl/Lua.
$client->DyeArmorBySlot(slot, red, green, blue, [use_tint = 0x00]);
client:DyeArmorBySlot(slot, red, green, blue, [use_tint = 0x00]);
Add MoveZoneInstance methods to Perl/Lua.
$client->MoveZoneInstance(instance_id);$client->MoveZoneInstanceGroup(instance_id);$client->MoveZoneInstanceRaid(instance_id);
client:MoveZoneInstance(instance_id);client:MoveZoneInstanceGroup(instance_id);client:MoveZoneInstanceRaid(instance_id);
Add cross-zone player move utilities.
quest::crosszonemoveplayerbycharid(character_id, zone_short_name);quest::crosszonemoveplayerbygroupid(group_id, zone_short_name);quest::crosszonemoveplayerbyraidid(raid_id, zone_short_name);quest::crosszonemoveplayerbyguildid(guild_id, zone_short_name);
eq.crosszonemoveplayerbycharid(character_id, zone_short_name);eq.crosszonemoveplayerbygroupid(group_id, zone_short_name);eq.crosszonemoveplayerbyraidid(raid_id, zone_short_name);eq.crosszonemoveplayerbyguildid(guild_id, zone_short_name);
Akkadius
Fixed an issue where when a client first enters a zone; an NPC may not be aware of their presence immediately
Fixed a UCS issue where a crash or another UCS connection would delete connection pointers; this should keep UCS connected more reliably
Lowered the rate in which animation packets are throttled to 500ms from 1000ms; this should keep faster animations from being gated from being sent
Kinglykrab
Fix $npc->RecalculateSkills() in Perl.
$client->MoveZone(zone_short_name);$client->MoveZoneGroup(zone_short_name);$client->MoveZoneRaid(zone_short_name);
client:MoveZone(zone_short_name);client:MoveZoneGroup(zone_short_name);client:MoveZoneRaid(zone_short_name);
quest::crosszoneassigntaskbycharid(character_id, task_id, enforce_level_requirement);quest::crosszoneassigntaskbygroupid(group_id, task_id, enforce_level_requirement);quest::crosszoneassigntaskbyraidid(raid_id, task_id, enforce_level_requirement);quest::crosszoneassigntaskbyguildid(guild_id, task_id, enforce_level_requirement);
eq.cross_zone_assign_task_by_char_id(character_id, task_id, enforce_level_requirement);eq.cross_zone_assign_task_by_group_id(group_id, task_id, enforce_level_requirement);eq.cross_zone_assign_task_by_raid_id(raid_id, task_id, enforce_level_requirement);eq.cross_zone_assign_task_by_guild_id(guild_id, task_id, enforce_level_requirement);
$client->GetDisciplineTimer(timer_id);$client->ResetDisciplineTimer(timer_id);
client:GetDisciplineTimer(timer_id);client:ResetDisciplineTimer(timer_id);
Noudess
Updated #grid show command to use alphabetic names so names display properly (numerics were getting stripped) and stacked the names of nodes that are in the same #loc.
Added code to make sure that mobs that call for help, complete that activity before starting to move toward target. As written (previously) a mob could be out of earshot of his neighbors because movement started immediately. It was a race condition that nearly always resulted in mobs within the attacked mobs assist radius not hearing the call.
Kinglykrab
Added command #findrace [name|id].
Added zone ID to #findzone.
Added eq.zone(short_name) to Lua.
Added eq.zone_group(short_name) to Lua.
Added eq.zone_raid(short_name) to Lua.
Added quest::zonegroup(short_name) to Perl.
Added quest::zoneraid(short_name) to Perl.
Noudess
SQL to load correct mods into faction_list_mod for Drakkin and Guktan races as well as Agnostic deity mods. Only to be used on databases converted to using the client faction ids.SQL found in optional SQL area as: utils/sql/git/optional/drakkin_guktan_faction_data.sql
​
Kinglykrab
$entity_list->GetNPCBySpawnID(spawn_id);
eq.get_entity_list():GetNPCBySpawnID(spawn_id);
quest::crosszonemessageplayerbygroupid(type, group_id, message);quest::crosszonemessageplayerbyraidid(type, raid_id, message);quest::crosszonemessageplayerbyguildid(type, guild_id, message);quest::crosszonesignalclientbygroupid(group_id, value);quest::crosszonesignalclientbyraidid(raid_id, value);quest::crosszonesignalclientbyguildid(guild_id, value);quest::crosszonesetentityvariablebygroupid(group_id, value);quest::crosszonesetentityvariablebyraidid(raid_id, value);quest::crosszonesetentityvariablebyguildid(guild_id, value);
eq.cross_zone_message_player_by_group_id(type, group_id, message);eq.cross_zone_message_player_by_raid_id(type, raid_id, message);eq.cross_zone_message_player_by_guild_id(type, guild_id, message);eq.cross_zone_signal_client_by_group_id(group_id, value);eq.cross_zone_signal_client_by_raid_id(group_id, value);eq.cross_zone_signal_client_by_guild_id(guild_id, value);eq.cross_zone_set_entity_variable_by_group_id(group_id, value);eq.cross_zone_set_entity_variable_by_raid_id(raid_id, value);eq.cross_zone_set_entity_variable_by_guild_id(guild_id, value);
Akkadius
Raid::GetRaidByClient
On PEQ we noticed via zone with high CPU footprint spending tons of time in in function Raid::GetRaidByClient where we excessively loop through all raids in zone, all members in the raid to return back a simple raid pointer. Now, we cache the pointer lookup instead of running the entire loop constantly. For perspective, with 100 toons in a zone all in a raid, you will easily see 4k/s calls to this function which adds up on a CPU profile (nuts)
CPU Profile https://gist.github.com/Akkadius/a5c55654d4b729697964f938c824030f Call Measurement Example
[email protected]:~$ tail -f ~/server/logs/**/*.log | grep "returning cached raid" | pv -lr 2>&1 >/dev/null[4.04k/s]
UCS
We also noticed UCS sucking up a lot of CPU with 1,500 players online
CPU Profile https://gist.github.com/Akkadius/14efe565caf468cc892293fd95cc0377​
Converted to a less aggressive loop frequency 31.25 FPS and converted to using UV library
No longer load characters into UCS context that are soft deleted
Fixed UCS bug where it would not reconnect properly after a crash / improper shutdown
Fixed UCS bug where it was not registering a new connection properly, and sending a "Not Available" to all zones right after it is in fact "Available"
Added Logging in zone that clearly says whether or not UCS is online or not
Properly removing UCS connected clients even if the /q /ex connections resolving by sending keepalive packets #735 this prevents UCS from looping over ghosted clients making unnecessary database calls and sending improper connected client counts
Removed tons of verbose LogInfo logging and replaced the calls for LogDebug as it was writing to disk excessively for mostly debugging related information
Zone
We are now properly shutting down zone processes by killing the UV loop instead of doing a hard process exit, allowing the zone to shut everything else down gracefully
Akkadius
Instead of purging immediately expired instances every 7.5 minutes, we will purge expired instances from the database table after they've been completely expired for an entire day every 7.5 minutes. The reason for this is that the code will still determine that an instance is expired when it needs to; but in order to not re-use the same instance ID not long after it had been freed while a zone is still online with the same instance ID, we're simply going to wait a grace period of 1 day to purge those entries as it will not harm anything
Client::SendToGuildHall() will send a client to a Guild Hall instance for 90 days based on a configurable rule. This will send the player to a Guild Hall instance regardless of whether they are in a Guild or not and it is up to the discretion of the server operator to check for guild id before making the call. If you are not guilded, you share an instance with other non-guilded players
We pull instance remaining time out of the database once on zone bootup because the timer class is returning the value in milliseconds which causes the values to overflow and improperly show remaining instance time for instances that are open for long period of time
Created new rule category Instances
RULE_INT(Instances, ReservedInstances, 30, "Will reserve this many instance ids for globals... probably not a good idea to change this while a server is running")RULE_BOOL(Instances, RecycleInstanceIds, true, "Will recycle free instance ids instead of gradually running out at 32k")RULE_INT(Instances, GuildHallExpirationDays, 90, "Amount of days before a Guild Hall instance expires")
This exports Lua / Perl method client->SendToGuildHall
Kinglykrab
Added getcharidbyname(name) to Perl/Lua.
quest::getcharidbyname(name);
eq.get_char_id_by_name(name);
Added getcharnamebyid(char_id) to Perl/Lua.
quest::getcharnamebyid(char_id);
eq.get_char_name_by_id(char_id);
Kinglykrab
Added getitemname(item_id) to Perl/Lua.
quest::getitemname(item_id);
eq.get_item_name(item_id);
Added getspellname(spell_id) to Perl/Lua.
quest::getspellname(spell_id);
eq.get_spell_name(item_id);
Added gettaskname(task_id) to Perl/Lua.
quest::gettaskname(task_id);
eq.get_task_name(task_id);
Added CheckInstanceByCharID(instance_id, char_id) to Perl/Lua.
quest::CheckInstanceByCharID(instance_id, char_id);
eq.check_instance_by_char_id(instance_id, char_id);
Noudess
Added a new field (always_aggro_foes) to npc_types. If non-zero, the npc/mob will always aggro foes regardless of intelligence or level. This was so mobs such as the int casters in Befallen, who will agro their enemies regardless of level and I didn't want to have to reduce the _int field of INT caster NPCs to achieve the aggro.
Added a 'monk' class special attack timer to class NPC
Monk bots will now use the ability
Tiger Clawon a seperate timer from the other disciplines - resulting in an additional attackBot usage of
Master Wu's Techniquenow falls inline with current client behavior (rules and all)Added bot owner option
monkwumessageto toggle a notification message to the bot's owner wheneverMWTtriggers (off by default .. use^oo monkwumessageto enable/disable)
Special Note:
By default, all classes process class attacks based on active timers. This involves checking attackability of target with every call - which is VERY expensive when done every server processing cycle since the timer is always 'ready.'
I added code to disable 'class' timers in classes that don't use them or are inactive because they don't have a skill. Class-based timers will not reactivate..but, skill-based ones will once a CalcBotStats call is made during the 'leveling' process. (If the skill is not available after leveling, the timer will disable itself again.)
Hopefully, this will help reduce bot cpu usage.
Please report any issues on our forums or in Discord - Thanks!
Auto Consent client options are now supported. Toggling these options results in consenting (or denying) a player's current corpses.
These options are now also saved and restored for characters.
The /consent and /deny commands for group, raid, and guild are now implemented. These commands are not case sensitive.
/consent group- adds current group id to all character corpses/consent raid- adds current raid id to all character corpses/consent guild- adds current guild id to all corpses and updates db/deny group|raid|guild- sets the consent type id to 0 on all corpses
Consent and deny commands are throttled to once every two seconds
When consenting a player by name, both the corpse owner and the player being consented receive a message for every (loaded) zone a corpse is in.
Corpses now store the list of consented player names. Previously clients stored a list of players they could drag corpses for.
Guild consent is persistent. The character_corpses table has a new guild_consent_idcolumn which is updated when a player issues a guild consent command. This means guild consented corpses may be dragged by guild members after a corpse is loaded (summoning the corpse to another zone or loading the corpse in a previously unloaded zone)
Group and raid consent are not persistent. Corpses will lose these consents when a corpse is summoned or if the corpse is loaded by a zone after consent was issued.
The handlers for EVENT_COMMAND and EVENT_BOT_COMMAND have been updated to allow a 'no change' behavior.
Script files using these event types will perform as before without the need to move the command scripting into them .. so long as there is no defined function for them.
Once a definition is given, the old method of using EVENT_SAY to handle them will no longer work and the new formatting must be applied.
If you have any questions, please direct them to our forums or the #support-quest-scripts channel in discord.
Akkadius
Unless new system rule Character:SoftDeletes (default: true) is disabled, characters will now no longer hard delete from all respective character tables and will only be marked as deleted via the newly created deleted_at column that can be found in the character_data table. This can make it far easier to recover accidentally deleted characters
EVENT_COMMAND now processes its own code and is no longer shared with EVENT_SAY
EVENT_BOT_COMMAND was added..but, will have limited functionality until more of the Bot class is exposed in the scripting apis
Both event types have new or updated entries on the Events page
In the template scripts, just replace the example command data with your own
Perl:
"command_name" => [<status_required>, "command_description"]Lua:
["command_name"] = {<status_required>, "command_description"}Anything in the
command_datahash will be automatically parsed upon any#helpcall - to include partial matching criteriaThe same is true for
bot_command_dataThese templates are not required for use..but, do provide a basic 'use' structure so that command coding is simplified and easier to implement
Older 'say' command code may still work as-is..though, it has not been tested
​
​
​
